netdev - Re: [net-next 6/8] bnx2x: Add known PHY type check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111127.170100.379387551488831733.davem@davemloft.net>
Date:	Sun, 27 Nov 2011 17:01:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	yanivr@...adcom.com
Cc:	netdev@...r.kernel.org, eilong@...adcom.com
Subject: Re: [net-next 6/8] bnx2x: Add known PHY type check

From: "Yaniv Rosner" <yanivr@...adcom.com>
Date: Sun, 27 Nov 2011 20:17:59 +0200

> +		if ((phy_type != PORT_HW_CFG_XGXS_EXT_PHY_TYPE_DIRECT) &&
> +			(phy_type != PORT_HW_CFG_XGXS_EXT_PHY_TYPE_NOT_CONN))
> +			return -EINVAL;

Please format this correctly:

		if ((phy_type != PORT_HW_CFG_XGXS_EXT_PHY_TYPE_DIRECT) &&
		    (phy_type != PORT_HW_CFG_XGXS_EXT_PHY_TYPE_NOT_CONN))
			return -EINVAL;

If you can't get the tabs right by hand, use something that does
it transparently for you such as C-mode in emacs.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html