netdev - Re: [PATCH] 9p: Reduce object size with CONFIG_NET_9P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Nov 2011 09:14:00 -0800
From:	Joe Perches <joe@...ches.com>
To:	Eric Van Hensbergen <ericvh@...il.com>
Cc:	Ron Minnich <rminnich@...dia.gov>,
	Latchesar Ionkov <lucho@...kov.net>,
	"David S. Miller" <davem@...emloft.net>,
	v9fs-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] 9p: Reduce object size with CONFIG_NET_9P_DEBUG

On Mon, 2011-11-28 at 09:10 -0600, Eric Van Hensbergen wrote:
> sorry, just got to reviewing this because of holidays.
> 
> On Fri, Nov 18, 2011 at 6:09 PM, Joe Perches <joe@...ches.com> wrote:
> > Reduce object size by deduplicating formats.
> >
> > Use vsprintf extension %pV.
> > Rename P9_DPRINTK uses to p9_debug, align arguments.
> > Add function for _p9_debug and macro to add __func__.
> > Add missing "\n"s to p9_debug uses.
> > Remove embedded function names as p9_debug adds it.
> > Remove P9_EPRINTK macro and convert use to pr_<level>.
> > Add and use pr_fmt and pr_<level>.
> >
> > $ size fs/9p/built-in.o*
> >   text    data     bss     dec     hex filename
> >  62133     984   16000   79117   1350d fs/9p/built-in.o.new
> >  67342     984   16928   85254   14d06 fs/9p/built-in.o.old
> >
> > Signed-off-by: Joe Perches <joe@...ches.com>
> 
> These changes seem reasonable enough, but since you only made changes
> in the fs/9p directory and not the net/9p directory which causes
> net/9p build to break with this patch.
> 
> CC      net/9p/client.o
> /home/ericvh/src/linux/v9fs-devel/net/9p/client.c: In function
> ‘get_protocol_version’:
> /home/ericvh/src/linux/v9fs-devel/net/9p/client.c:84:3: error:
> implicit declaration of function ‘P9_DPRINTK’

Sorry 'bout that.
I'll fix it and resubmit later.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html