netdev - Re: [PATCH] natsemi: make cable length magic configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Nov 2011 17:51:04 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
CC:	<jdelvare@...e.de>, <netdev@...r.kernel.org>, <thockin@...kin.org>,
	<okir@...e.de>
Subject: Re: [PATCH] natsemi: make cable length magic configurable

On Fri, 2011-11-25 at 01:37 -0500, David Miller wrote:
> From: Jean Delvare <jdelvare@...e.de>
> Date: Thu, 24 Nov 2011 14:43:59 +0100
> 
> > We had a customer report concerning problems with a Natsemi DP83815-D
> > and long cables. With 100m cables, the network would be essentially dead,
> > not a single packet would get through either way. We had to apply the
> > patch below to make it work.
> 
> Please do not add new private device driver module knobs.
> 
> Instead, add generic flags to the ethtool interface or similar to
> control device behavior.

This isn't a generic flag; it seems to be a workaround for a specific
bug that unfortunately can't be automatic.

That's why I suggested an ethtool private flag.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html