netdev - Re: [PATCH v4 02/10] net: Add queue state xoff flag for stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111129.122746.246022903745748780.davem@davemloft.net>
Date:	Tue, 29 Nov 2011 12:27:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jhs@...atatu.com, hadi@...erus.ca
Cc:	therbert@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH v4 02/10] net: Add queue state xoff flag for stack

From: jamal <hadi@...erus.ca>
Date: Tue, 29 Nov 2011 08:12:51 -0500

> On Mon, 2011-11-28 at 18:32 -0800, Tom Herbert wrote:
>>  
>>  enum netdev_queue_state_t {
>> -       __QUEUE_STATE_XOFF,
>> +       __QUEUE_STATE_DRV_XOFF,
>> +       __QUEUE_STATE_STACK_XOFF,
>>         __QUEUE_STATE_FROZEN,
> 
> QUEUE_STATE_DRV_XOFF seems to be a rename of __QUEUE_STATE_XOFF
> no issues there.
> Is inserting __QUEUE_STATE_STACK_XOFF going to cause any issues?
> Typically, you should insert new things at the end.

I doubt the ordering matters here, and any such dependency is a bug.
:-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html