[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2892320.ttUs8EtPs3@sifl>
Date: Tue, 29 Nov 2011 12:47:54 -0500
From: Paul Moore <paul@...l-moore.com>
To: Dan Carpenter <dan.carpenter@...cle.com>
Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [patch] net/netlabel: copy and paste bug in netlbl_cfg_unlbl_map_add()
On Thursday, November 24, 2011 10:18:20 AM Dan Carpenter wrote:
> This was copy and pasted from the IPv4 code. We're calling the
> ip4 version of that function and map4 is NULL.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> diff --git a/net/netlabel/netlabel_kapi.c b/net/netlabel/netlabel_kapi.c
> index 8ed67dcc..3735297 100644
> --- a/net/netlabel/netlabel_kapi.c
> +++ b/net/netlabel/netlabel_kapi.c
> @@ -162,8 +162,8 @@ int netlbl_cfg_unlbl_map_add(const char *domain,
> map6->list.addr.s6_addr32[3] &= mask6->s6_addr32[3];
> map6->list.mask = *mask6;
> map6->list.valid = 1;
> - ret_val = netlbl_af4list_add(&map4->list,
> - &addrmap->list4);
> + ret_val = netlbl_af6list_add(&map6->list,
> + &addrmap->list6);
> if (ret_val != 0)
> goto cfg_unlbl_map_add_failure;
> break;
Thanks for fixing this. I actually stumbled across this just last week while
working on the CALIPSO stuff and queued up a patch but didn't get a chance to
verify it before Thanksgiving - you just saved me the effort :)
--
paul moore
www.paul-moore.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists