lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Nov 2011 01:18:02 -0500 (EST) From: David Miller <davem@...emloft.net> To: ralf@...ux-mips.org Cc: netdev@...r.kernel.org, linux-hams@...r.kernel.org, dan.carpenter@...cle.com, wharms@....de, thomas@...erried.de Subject: Re: [PATCH 2/4] NET: NETROM: When adding a route verify length of mnemonic string. From: Ralf Baechle <ralf@...ux-mips.org> Date: Fri, 25 Nov 2011 09:08:49 +0000 > struct nr_route_struct's mnemonic permits a string of up to 7 bytes to be > used. If userland passes a not zero terminated string to the kernel adding > a node to the routing table might result in the kernel attempting to read > copy a too long string. > > Mnemonic is part of the NET/ROM routing protocol; NET/ROM routing table > updates only broadcast 6 bytes. The 7th byte in the mnemonic array exists > only as a \0 termination character for the kernel code's convenience. > > Fixed by rejecting mnemonic strings that have no terminating \0 in the first > 7 characters. Do this test only NETROM_NODE to avoid breaking NETROM_NEIGH > where userland might passing an uninitialized mnemonic field. > > Initial patch by Dan Carpenter <dan.carpenter@...cle.com>. > > Signed-off-by: Ralf Baechle <ralf@...ux-mips.org> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists