netdev - Re: [PATCH net-next v4 0/4] can: cc770: add support for the Bosch CC770 and Intel AN82527

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ED4B93B.10709@pengutronix.de>
Date:	Tue, 29 Nov 2011 11:51:39 +0100
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Wolfgang Grandegger <wg@...ndegger.com>
CC:	netdev@...r.kernel.org, linux-can@...r.kernel.org,
	socketcan-users@...ts.berlios.de, IreneV <boir1@...dex.ru>,
	Stanislav Yelenskiy <stanislavelensky@...oo.com>,
	Wolfgang Zarre <info@...ax.com>
Subject: Re: [PATCH net-next v4 0/4] can: cc770: add support for the Bosch
 CC770 and Intel AN82527

On 11/29/2011 11:47 AM, Marc Kleine-Budde wrote:
> On 11/29/2011 10:11 AM, Wolfgang Grandegger wrote:
>> Already since a while we have support for the Bosch CC770 and Intel
>> AN82527 CAN controllers in our out-of-tree Socket-CAN repository.
>>
>> In the meantime I found a TQM855L board with two AN82527 on it,
>> which allowed me to provide and test a generic platform driver
>> as well.
>>
>> Changes since v1:
>>
>> - remove version.h includes
>> - some minor corrections in the ISA bus driver
>> - add platform header file to the driver core
>> - add generic platform driver
>> - add and update device tree nodes for tqm8xx and tqm8548
>>
>> Changes since v2:
>>
>> - correct license text as suggest by Oliver Hartkopp
>> - use the new module_platform_driver function
>> - provide get_berr_counter callback for cc770
>> - improve CAN error state change handling
>> - more comprehensive cc770_isa driver description
>>
>> Changes since v3:
>>
>> - pre-define pr_fmt()
>> - use KBUILD_MODNAME instead of DRV_NAME
>> - use ARRAY_SIZE() whenever appropriate
>> - use variable name "o" for message objects consistantly
>> - use proper error code for cc770_probe_chip
>> - remove unneeded member priv->open_time
>> - remove unnecessary masking of u8 variables (with 0xff)
>> - use "!skb" instead of "skb == NULL"
>> - CC770_MSG_MAX now limits the number of messages read in the ISR
>> - use "|" instead of "+" to combine bit masks
>> - remove return code check of platform_get_resource() in remove function
>> - remove postal address from GPL copyright text
>> - fix WARNING: __packed is preferred over __attribute__((packed))
>> - some more minor fixes (casts, white space, etc.)
> 
> Feel free to add by Acked-by to patches 1 and 2.
                   ^^
my

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (263 bytes)