netdev - Re: [PATCH 04/12] [MAC802154] mac802154: TX data path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Nov 2011 19:56:16 +0400
From:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
To:	Alexander Smirnov <alex.bluesman.smirnov@...il.com>
Cc:	linux-zigbee-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [PATCH 04/12] [MAC802154] mac802154: TX data path

Hello,

On Wed, Nov 30, 2011 at 6:23 PM, Alexander Smirnov
<alex.bluesman.smirnov@...il.com> wrote:
> Main TX data path implementation between upper and physical layers.
>
> Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
> ---
>  net/mac802154/Makefile         |    2 +-
>  net/mac802154/ieee802154_dev.c |    3 +-
>  net/mac802154/tx.c             |  102 ++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 105 insertions(+), 2 deletions(-)
>  create mode 100644 net/mac802154/tx.c
>
> diff --git a/net/mac802154/Makefile b/net/mac802154/Makefile
> index e00fe47..490beef 100644
> --- a/net/mac802154/Makefile
> +++ b/net/mac802154/Makefile
> @@ -1,2 +1,2 @@
>  obj-$(CONFIG_MAC802154)        += mac802154.o
> -mac802154-objs         := ieee802154_dev.o rx.o
> +mac802154-objs         := ieee802154_dev.o rx.o tx.o
> diff --git a/net/mac802154/ieee802154_dev.c b/net/mac802154/ieee802154_dev.c
> index 42f95b2..e90d336 100644
> --- a/net/mac802154/ieee802154_dev.c
> +++ b/net/mac802154/ieee802154_dev.c
> @@ -31,7 +31,8 @@ struct ieee802154_dev *ieee802154_alloc_device(size_t priv_size,
>        struct wpan_phy *phy;
>        struct mac802154_priv *priv;
>
> -       if (!ops || !ops->xmit || !ops->ed || !ops->start || !ops->stop) {
> +       if (!ops || !ops->xmit || !ops->ed || !ops->start || !ops->stop ||
> +           !ops->set_channel) {
>                printk(KERN_ERR
>                        "Undefined IEEE802.15.4 device operations\n");
>                return NULL;

Shan't this be present in one of the previous patches instead? Because
it's illogical to include the check here and not before, if you define
set_channel
operation in previous patch.

-- 
With best wishes
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html