netdev - Re: [PATCH] bridge: master device stuck in no-carrier state forever when in user-stp mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111129160656.7a96375e@nehalam.linuxnetplumber.net>
Date:	Tue, 29 Nov 2011 16:06:56 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	David Miller <davem@...emloft.net>
Cc:	vitas@...factor.kiev.ua, netdev@...r.kernel.org,
	bridge@...ts.linux-foundation.org, michael.tremer@...ire.org
Subject: Re: [PATCH] bridge: master device stuck in no-carrier state forever
 when in user-stp mode

On Tue, 29 Nov 2011 18:54:33 -0500 (EST)
David Miller <davem@...emloft.net> wrote:

> From: Vitalii Demianets <vitas@...factor.kiev.ua>
> Date: Fri, 25 Nov 2011 12:16:37 +0200
> 
> > When in user-stp mode, bridge master do not follow state of its slaves, so 
> > after the following sequence of events it can stuck forever in no-carrier 
> > state:
> > 1) turn stp off
> > 2) put all slaves down - master device will follow their state and also go in 
> > no-carrier state
> > 3) turn stp on with bridge-stp script returning 0 (go to the user-stp mode)
> > Now bridge master won't follow slaves' state and will never reach running 
> > state.
> > 
> > This patch solves the problem by making user-stp and kernel-stp behavior 
> > similar regarding master following slaves' states.
> > 
> > Signed-off-by: Vitalii Demianets <vitas@...factor.kiev.ua>
> 
> Stephen, please review this patch, thanks.

Agree that it is a problem, but want to fix the code up. The logic
can be done slightly cleaner.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html