netdev - Re: [RFC net-next] Include selection of congestion control algorithm in that which is inherited across an accept() call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1322631613.2596.70.camel@edumazet-laptop>
Date:	Wed, 30 Nov 2011 06:40:13 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Rick Jones <raj@...dy.cup.hp.com>
Cc:	netdev@...r.kernel.org, Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [RFC net-next] Include selection of congestion control
 algorithm in that which is inherited across an accept() call

Le mercredi 30 novembre 2011 à 06:21 +0100, Eric Dumazet a écrit :

> So my suggestion would be to use this two lines patch instead :
> 
> diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
> index 945efff..6b066e2 100644
> --- a/net/ipv4/tcp_minisocks.c
> +++ b/net/ipv4/tcp_minisocks.c
> @@ -495,8 +495,6 @@ struct sock *tcp_create_openreq_child(struct sock *sk, struct request_sock *req,
>  		newtp->frto_counter = 0;
>  		newtp->frto_highmark = 0;
>  
> -		newicsk->icsk_ca_ops = &tcp_init_congestion_ops;
> -
>  		tcp_set_ca_state(newsk, TCP_CA_Open);
>  		tcp_init_xmit_timers(newsk);
>  		skb_queue_head_init(&newtp->out_of_order_queue);
> 

Please test this change and if its OK, resubmit your patch, with
appropriate Documentation change, as pointed out by Yuchung Cheng 

(file to change : Documentation/networking/ip-sysctl.txt )

You could clearly state that the congestion control eventually
chosen by the listener socket takes precedence over the system default
tcp congestion value.

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html