netdev - Re: [PATCH v2] net: fec: Select the FEC driver by default for i.MX SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111130132536.GD26618@pengutronix.de>
Date:	Wed, 30 Nov 2011 14:25:36 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Fabio Estevam <fabio.estevam@...escale.com>
Cc:	linux-arm-kernel@...ts.infradead.org, kernel@...gutronix.de,
	shawn.guo@...escale.com, davem@...emloft.net,
	netdev@...r.kernel.org, marek.vasut@...il.com
Subject: Re: [PATCH v2] net: fec: Select the FEC driver by default for i.MX
 SoCs

On Wed, Nov 30, 2011 at 09:31:57AM -0200, Fabio Estevam wrote:
> Let the FEC driver be built by default.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
Just one small nitpick below. Other than that:

Suggested-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

> ---
> Changes since v1: 
> Move the FEC selection into Kconfig instead of .config file
> 
>  drivers/net/ethernet/freescale/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
> index c520cfd..ae269ad 100644
> --- a/drivers/net/ethernet/freescale/Kconfig
> +++ b/drivers/net/ethernet/freescale/Kconfig
> @@ -22,6 +22,7 @@ if NET_VENDOR_FREESCALE
>  
>  config FEC
>  	bool "FEC ethernet controller (of ColdFire and some i.MX CPUs)"
> +	default ARCH_MXC || ARCH_MXS if ARM
>  	depends on (M523x || M527x || M5272 || M528x || M520x || M532x || \
>  		   ARCH_MXC || ARCH_MXS)
I'd write the depends line first, then default and then select.

Best regards
Uwe

>  	select PHYLIB

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html