lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cfd2e2c26063da002d8afe76991ff0c1@localhost>
Date:	Thu, 01 Dec 2011 09:25:20 +0100
From:	Hagen Paul Pfeifer <hagen@...u.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	<netdev@...r.kernel.org>, Stephen Hemminger <shemminger@...tta.com>
Subject: Re: [PATCH v3 net-next 2/2] netem: add cell concept to simulate  special MAC behavior


On Thu, 01 Dec 2011 04:30:25 +0100, Eric Dumazet wrote:

> Thats a multiply instead of a divide. On many cpus thats a lot faster.
>
> Think about a super packet (TSO) of 65000 bytes and cell_size=64

I've never imagined that I am going to say the following: you are wrong,
Eric! (ok, maybe you are right ;-)

TSO and Netem is a no-go. With netem you are strongly advised to disable
offloading. I mean TSO will result in _one_ delay of several minutes,
followed by a burst of packets. Instead of packets spaced by several
seconds (with the rate of 1000byte/s) - which is what you wan't.

To sum up: skb->len is _never_ larger as the MTU for (normal, correct)
network emulation setups with netem. This was the assumption why I
preferred the iterative solution over the div/mod solution.

Did I miss something?

Hagen

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ