[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAEP_g=8aqdK3bLqGzUgnLXfq2uapbPMb7-mpHpq1WUzsb91VJQ@mail.gmail.com>
Date: Fri, 2 Dec 2011 15:00:42 -0800
From: Jesse Gross <jesse@...ira.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: Simon Horman <horms@...ge.net.au>,
"Fischer, Anna" <anna.fischer@...com>,
"jhs@...atatu.com" <jhs@...atatu.com>,
David Miller <davem@...emloft.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"dev@...nvswitch.org" <dev@...nvswitch.org>
Subject: Re: [GIT PULL v2] Open vSwitch
On Wed, Nov 30, 2011 at 11:52 PM, Herbert Xu
<herbert@...dor.apana.org.au> wrote:
> On Thu, Dec 01, 2011 at 04:24:18PM +0900, Simon Horman wrote:
>>
>> So while I agree that optimizing the hash is a good idea. I don't believe
>> it is a bottle-neck at this point. Though I could be convinced otherwise if
>> long collision chains could be constructed with relatively few flows.
>> Something I had not considered until I rad your email just now.
>
> It's not an optimisation issue, but a security one. If you leave
> a hash like this with a constant seed, an attacker would have an
> infinite amount of time to find collisions.
>
> Rehashing isn't all that difficult.
Yeah, I agree. We'll fix this for the next version of the patch series, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists