netdev - Re: [PATCH net-next] r8169: Support for byte queue limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFdo_mVwRgB3OEBA7=nMcemr1x1WLkXC05UAnDW_n5gyYy9W=A@mail.gmail.com>
Date:	Fri, 2 Dec 2011 15:54:12 +0100
From:	Igor Maravić <igorm@....rs>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	Realtek linux nic maintainers <nic_swsd@...ltek.com>,
	Francois Romieu <romieu@...zoreil.com>
Subject: Re: [PATCH net-next] r8169: Support for byte queue limits

> Hmm... What about rtl8169_tx_clear_range() or rtl8169_tx_clear() ?
>

You mean we should put netdev_reset_queue() in those functions?

I think that we shouldn't put any thing in these functions.

When ever they are called, they are precede/followed by function
rtl8169_hw_reset() which calls rtl_hw_reset() which calls
rtl8169_init_ring_indexes() in which I've put netdev_reset_queue()

Only time when rtl8169_tx_clear_range() isn't preceded/followed by
rtl8169_hw_reset() is in function rtl8169_xmit_frags(). In that
function it's
called only in case there's an error. In case there was an error in that
function, netdev_sent_queue() will never be called, so we are going to have
accurate length of queue.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html