netdev - Re: [PATCH] e1000e: Fix bug for e1000e interrupt default mode select.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1322848522.2807.3.camel@bwh-desktop>
Date:	Fri, 2 Dec 2011 17:55:22 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Kumar Gala <galak@...nel.crashing.org>
CC:	<jeffrey.t.kirsher@...el.com>, <jesse.brandeburg@...el.com>,
	<e1000-devel@...ts.sourceforge.net>, <netdev@...r.kernel.org>,
	Prabhakar <prabhakar@...escale.com>
Subject: Re: [PATCH] e1000e: Fix bug for e1000e interrupt default mode
 select.

On Fri, 2011-12-02 at 01:11 -0600, Kumar Gala wrote:
> From: Prabhakar <prabhakar@...escale.com>
> 
> If the kernel config does not have MSI enabled (CONFIG_PCI_MSI) the driver
> should not default to MSI interrupt mode but legacy interrupt mode.

It is supposed to automatically fall-back to legacy interrupt mode.
Does that not work?

Also, are there really systems with PCI Express and no MSI support?

Ben.

> Signed-off-by: Jin Qing <b24347@...escale.com>
> Signed-off-by: Prabhakar <prabhakar@...escale.com>
> Signed-off-by: Kumar Gala <galak@...nel.crashing.org>
> ---
>  drivers/net/ethernet/intel/e1000e/param.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/e1000e/param.c b/drivers/net/ethernet/intel/e1000e/param.c
> index 20e93b0..18c35c6 100644
> --- a/drivers/net/ethernet/intel/e1000e/param.c
> +++ b/drivers/net/ethernet/intel/e1000e/param.c
> @@ -388,8 +388,13 @@ void __devinit e1000e_check_options(struct e1000_adapter *adapter)
>  		static struct e1000_option opt = {
>  			.type = range_option,
>  			.name = "Interrupt Mode",
> +#ifdef CONFIG_PCI_MSI
>  			.err  = "defaulting to 2 (MSI-X)",
>  			.def  = E1000E_INT_MODE_MSIX,
> +#else
> +			.err  = "defaulting to 0 (Legacy)",
> +			.def  = E1000E_INT_MODE_LEGACY,
> +#endif
>  			.arg  = { .r = { .min = MIN_INTMODE,
>  					 .max = MAX_INTMODE } }
>  		};

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html