netdev - Re: [PATCH] pq3: Add default tbi address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKWjMd52BhV0j3R93Cw8usBxZwbMCY70x=BAmV7dH-WyWRUyFA@mail.gmail.com>
Date:	Sat, 3 Dec 2011 14:15:44 -0600
From:	Andy Fleming <afleming@...il.com>
To:	Kumar Gala <galak@...nel.crashing.org>
Cc:	Andy Fleming <afleming@...escale.com>,
	David Miller <davem@...emloft.net>,
	linuxppc-dev@...ts.ozlabs.org, netdev@...r.kernel.org
Subject: Re: [PATCH] pq3: Add default tbi address

>> arch/powerpc/boot/dts/fsl/pq3-etsec1-0.dtsi |    5 +++++
>> arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi |    5 +++++
>> 2 files changed, 10 insertions(+), 0 deletions(-)
>
> This doesn't seem correct, meaning this should really be in the board .dts not in the IP.
>
> I think the driver should check and warn if this property doesn't exist.

Hmm... in principle, I agree with you. I suppose I was just being
lazy, and avoiding changing all the device trees again. However, it's
not an unreasonable default. A search through *all* of the device
trees for the tbi node indicates that 0x11 is chosen about 50% of the
time.

However, I'll devise a patch which complains if the node isn't found,
and another patch which modifies all of the offending device trees.

Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html