netdev - Re: [PATCHv2 net-next 2/4] caif: Add support for CAIF over CDC NCM USB interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111204.131836.231887333540568891.davem@davemloft.net>
Date:	Sun, 04 Dec 2011 13:18:36 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sjur.brandeland@...ricsson.com
Cc:	netdev@...r.kernel.org, alexey.orishko@...ricsson.com,
	eric.dumazet@...il.com
Subject: Re: [PATCHv2 net-next 2/4] caif: Add support for CAIF over CDC NCM
 USB interface

From: Sjur Brændeland <sjur.brandeland@...ricsson.com>
Date: Sun,  4 Dec 2011 11:10:48 +0100

> NCM 1.0 does not support anything but Ethernet framing, hence
> CAIF payload will be put into Ethernet frames.
> 
> Discovery is based on fixed USB vendor 0x04cc (ST-Ericsson),
> product-id 0x230f (NCM). In this variant only CAIF payload is sent over
> the NCM interface.
> 
> The CAIF stack (cfusbl.c) will when USB interface register first check if
> we got a CDC NCM USB interface with the right VID, PID.
> It will then read the device's Ethernet address and create a 'template'
> Ethernet TX header, using a broadcast address as the destination address,
> and EthType 0x88b5 (802.1 Local Experimental - vendor specific).
> 
> A protocol handler for 0x88b5 is setup for reception of CAIF frames from
> the CDC NCM USB interface.
> 
> Signed-off-by: Sjur Brændeland <sjur.brandeland@...ricsson.com>

Please make this feature a tristate and make the init and exit
routines executed via the normal modula_init()/module_exit()
mechanisms.

That way you don't need that dopey header file to export the
init and exit routines, and you don't need to ifdef crap up the
code CAIF code to invoke them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html