| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 Dec 2011 09:55:31 +0200 From: Lucian Adrian Grijincu <lucian.grijincu@...il.com> To: "Eric W . Biederman" <ebiederm@...ssion.com>, linux-kernel <linux-kernel@...r.kernel.org> Cc: netdev@...r.kernel.org, Octavian Purdila <tavi@...pub.ro>, "David S . Miller" <davem@...emloft.net>, Alexey Dobriyan <adobriyan@...il.com>, Damien Millescamps <damien.millescamps@...nd.com> Subject: v6: faster tree-based sysctl implementation This is version 6 of a patch series that introduces a faster/leaner sysctl internal implementation. git://github.com/luciang/linux-2.6-new-sysctl.git v6-new-sysctl-alg A subset of patches that add the minimal set of patches with the new algorithm is here: git://github.com/luciang/linux-2.6-new-sysctl.git v6-new-sysctl-alg-slim = Stats = $ time modprobe dummy numdummies=N Without this patch series :( - ipv4 only - N=1000 time= 0m 07s - N=2000 time= 0m 38s - N=4000 time= 4m 01s - ipv4 and ipv6 - N=1000 time= 0m 35s - N=2000 time= 3m 09s - N=4000 time=14m 27s With this patch series :) - ipv4 only - N=1000 time= 0m 0.31s - N=2000 time= 0m 1.23s - N=4000 time= 0m 5.14s - N=8000 time= 0m 20.20s - ipv4 and ipv6 - N=1000 time= 0m 0.70s - N=2000 time= 0m 1.93s - N=4000 time= 0m 7.03s - N=8000 time= 0m 40.89s = Changes = since v5: - https://lkml.org/lkml/2011/6/2/332 - nothing much because of lack of review. Echo, echo, echo ... :) - minor tweaks - rebased on 3.2-rc4 since v4: - http://thread.gmane.org/gmane.linux.network/196495/focus=1144143 - rebased on 3.0-rc1 - added a new patch manually register kernel/usermodehelper which was added in 3.0-rc1 - minor changes to the "sysctl: simplify find_in_table" patch since v3: - http://thread.gmane.org/gmane.linux.network/196495/ - removed a bad patch that shrinked a counter from int to u8 since v2: - http://thread.gmane.org/gmane.linux.kernel/1137032/focus=3D194748 - added a compatibility layer to support old registering complex sysctl trees. This layer will be deleted once all users of the old are changed. - subdirectories and netns correspondent dirs are now held in rbtrees - split of from the patches that make changes in the rest of the tree - rebased on top of 2.6.39 since v1: - http://thread.gmane.org/gmane.linux.kernel/1133667 - rebased on top of 2.6.39-rc6 - split the patch that adds the new algorithm and data structures. - fixed a few bugs lingering in the old code - shrinked a reference counter - added a new reference counter to maintain ownership information - added method to register an empty sysctl dir and converted some users - added checks enforcing the rule that a non-netns specific directory may not be registered after a netns specific one has already been registered. - added cookie support: register a piece of data with the header to be used to make simple conversions on the ctl_table. = Summary = Part 1: introduce compatibility layer: sysctl: introduce temporary sysctl wrappers sysctl: register only tables of sysctl files Part 2: minimal changes to sysctl users: sysctl: call sysctl_init before the first sysctl registration sysctl: no-child: manually register kernel/random sysctl: no-child: manually register kernel/usermodehelper sysctl: no-child: manually register kernel/keys sysctl: no-child: manually register fs/inotify sysctl: no-child: manually register fs/epoll sysctl: no-child: manually register root tables Part 3: cleanups simplifying the new algorithm: sysctl: faster reimplementation of sysctl_check_table sysctl: remove useless ctl_table->parent field sysctl: simplify find_in_table sysctl: sysctl_head_grab defaults to root header on NULL sysctl: delete useless grab_header function sysctl: rename ->used to ->ctl_use_refs sysctl: rename sysctl_head_grab/finish to sysctl_use_header/unuse sysctl: rename sysctl_head_next to sysctl_use_next_header sysctl: split ->count into ctl_procfs_refs and ctl_header_refs sysctl: rename sysctl_head_get/put to sysctl_proc_inode_get/put sysctl: rename (un)use_table to __sysctl_(un)use_header sysctl: simplify ->permissions hook sysctl: move removal from list out of start_unregistering sysctl: introduce ctl_table_group and ctl_table_group_ops Part 4: new algorithm/data structures: sysctl: faster tree-based sysctl implementation Part 5: checks/warns requested during review: sysctl: add duplicate entry and sanity ctl_table checks sysctl: alloc ctl_table_header with kmem_cache sysctl: check netns-specific registration order respected sysctl: warn if registration/unregistration order is not respected sysctl: always perform sysctl checks sysctl: reorder members of ctl_table_header (cleanup) sysctl: add ctl_type member Part 6: further performance optimisations: sysctl: replace subdirectory list with rbtree sysctl: replace netns corresp list with rbtree sysctl: union-ize some ctl_table_header fields Part 7: Eric requested ability to register an empty dir: sysctl: add register_sysctl_dir: register an empty sysctl directory Part 8: unrequested feature I'd like to piggy back :) sysctl: add ctl_cookie and ctl_cookie_handler sysctl: add cookie to __register_sysctl_paths sysctl: add register_net_sysctl_table_net_cookie drivers/char/random.c | 27 +- fs/eventpoll.c | 22 +- fs/notify/inotify/inotify_user.c | 22 +- fs/proc/inode.c | 2 +- fs/proc/proc_sysctl.c | 236 +++++--- include/linux/inotify.h | 2 - include/linux/key.h | 3 - include/linux/kmod.h | 3 - include/linux/poll.h | 2 - include/linux/sysctl.h | 221 +++++--- include/net/net_namespace.h | 4 +- init/main.c | 1 + kernel/Makefile | 5 +- kernel/kmod.c | 14 +- kernel/sysctl.c | 1170 ++++++++++++++++++++++++++++---------- kernel/sysctl_check.c | 316 +++++++---- lib/Kconfig.debug | 8 - net/sysctl_net.c | 86 ++-- security/keys/key.c | 7 + security/keys/sysctl.c | 18 +- 20 files changed, 1500 insertions(+), 669 deletions(-) -- 1.7.5.4 -- . ..: Lucian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists