netdev - Re: [net-next 1/6] e1000e: Avoid wrong check on TX hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111205114956.439c00bc@asterix.rh>
Date:	Mon, 5 Dec 2011 11:49:56 -0200
From:	Flavio Leitner <fbl@...hat.com>
To:	Michael Wang <wangyun@...ux.vnet.ibm.com>
Cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>, davem@...emloft.net,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 1/6] e1000e: Avoid wrong check on TX hang

On Mon, 05 Dec 2011 16:37:02 +0800
Michael Wang <wangyun@...ux.vnet.ibm.com> wrote:

> Hi, Jeff
> 
> Please reserve "From: Michael Wang <wangyun@...ux.vnet.ibm.com>" in
> content. And because Flavio not respond these days, I add his name
> for him.
> 
> Thanks,
> Michael Wang
> 
> On 12/05/2011 04:20 PM, Jeff Kirsher wrote:
> 
> > Based on the original patch submitted my Michael Wang
> > <wangyun@...ux.vnet.ibm.com>.
> 
> From: Michael Wang <wangyun@...ux.vnet.ibm.com>
> 
> > Descriptors may not be write-back while checking TX hang with flag
> > FLAG2_DMA_BURST on.
> > So when we detect hang, we just flush the descriptor and detect
> > again for once.
> > 
> > -v2 change 1 to true and 0 to false and remove extra ()
> > 
> > CC: Michael Wang <wangyun@...ux.vnet.ibm.com>
> > CC: Flavio Leitner <fbl@...hat.com>
> 
> Signed-off-by: Michael Wang <wangyun@...ux.vnet.ibm.com>

Agree with the fixes. thanks,
Signed-off-by: Flavio Leitner <fbl@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html