netdev - Re: [PATCH 1/11] inet_diag: Partly rename inet_ to sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111206.134202.1463574805110883510.davem@davemloft.net>
Date:	Tue, 06 Dec 2011 13:42:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	xemul@...allels.com, netdev@...r.kernel.org
Subject: Re: [PATCH 1/11] inet_diag: Partly rename inet_ to sock_

From: Stephen Hemminger <shemminger@...tta.com>
Date: Tue, 6 Dec 2011 10:24:47 -0800

> On Tue, 06 Dec 2011 21:56:43 +0400
> Pavel Emelyanov <xemul@...allels.com> wrote:
> 
>> diff --git a/include/linux/netlink.h b/include/linux/netlink.h
>> index 8374d29..9827ebf 100644
>> --- a/include/linux/netlink.h
>> +++ b/include/linux/netlink.h
>> @@ -8,7 +8,7 @@
>>  #define NETLINK_UNUSED		1	/* Unused number				*/
>>  #define NETLINK_USERSOCK	2	/* Reserved for user mode socket protocols 	*/
>>  #define NETLINK_FIREWALL	3	/* Firewalling hook				*/
>> -#define NETLINK_INET_DIAG	4	/* INET socket monitoring			*/
>> +#define NETLINK_SOCK_DIAG	4	/* socket monitoring				*/
>>  #define NETLINK_NFLOG		5	/* netfilter/iptables ULOG */
>>  #define NETLINK_XFRM		6	/* ipsec */
>>  #define NETLINK_SELINUX		7	/* SELinux event notifications */
> 
> This is a header file that is stripped and exported by other
> tools. You can add new entries but need to keep existing define's
> to avoid breaking source compatibility.

Indeed, NETLINK_INET_DIAG must be kept around forever because that's what userland
source code references.

I'll fix this up when applying Pavel's patches, by simply adding a new alias that
userland can start being coverted over to use.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html