netdev - Re: [PATCH net-next] bnx2x: Fix compile errors if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1323209811.11998.3.camel@lb-tlvb-eilong.il.broadcom.com>
Date:	Wed, 7 Dec 2011 00:16:51 +0200
From:	"Eilon Greenstein" <eilong@...adcom.com>
To:	"Michael Chan" <mchan@...adcom.com>,
	"Joe Perches" <joe@...ches.com>,
	"Dmitry Kravkov" <dmitry@...adcom.com>
cc:	"Eric Dumazet" <eric.dumazet@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Barak Witkowski" <barak@...adcom.com>
Subject: Re: [PATCH net-next] bnx2x: Fix compile errors if CONFIG_CNIC
 is not set

On Tue, 2011-12-06 at 13:42 -0800, Michael Chan wrote:
> On Tue, 2011-12-06 at 13:25 -0800, Joe Perches wrote:
> > On Tue, 2011-12-06 at 22:03 +0100, Eric Dumazet wrote:
> > > Le mardi 06 décembre 2011 à 12:58 -0800, Michael Chan a écrit :
> > > > Don't provide FCoE and iSCSI statistics to management firmware if
> > > > CONFIG_CNIC is not set.  Some needed structure fields are not defined
> > > > without CONFIG_CNIC.
> > > Thanks for the fast answer, and yes, no more build error :)
> > 
> > That works, but is that the best solution?
> > 
> > Another option is for bnx2x_handle_drv_info_req
> > to return DRV_MSG_CODE_DRV_INFO_NACK
> > 
> 
> Eilon (bnx2x lead maintainer) will need to decide which is the most
> appropriate solution as he is most familiar with the firmware.  I don't
> know if sending NACK to the firmware will have other negative effects or
> not.  Eilon should be online in about 8 hours and he can send a
> follow-up patch if necessary.
> 
> > Maybe like:
> > 
> > 	switch (op_code) {
> > 	case ETH_STATS_OPCODE:
> > 		bnx2x_drv_info_ether_stat(bp);
> > 		break;
> > #ifdef BCM_CNIC
> > 	case FCOE_STATS_OPCODE:
> > 		bnx2x_drv_info_fcoe_stat(bp);
> > 		break;
> > 	case ISCSI_STATS_OPCODE:
> > 		bnx2x_drv_info_iscsi_stat(bp);
> > 		break;
> > #endif
> > 	default:
> > 		/* if op code isn't supported - send NACK */
> > 		bnx2x_fw_command(bp, DRV_MSG_CODE_DRV_INFO_NACK, 0);
> > 		return;
> > 	}
> > 
> > 
> > 
> 

Joe is right. This latest patch breaks the FW assumption, but at least
everything compiles now, so it is not as urgent. We will send a patch in
that spirit in the morning.

Thanks,
Eilon



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html