netdev - Re: Patch is wrong

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111206101036.1d50e8ac@asterix.rh>
Date:	Tue, 6 Dec 2011 10:10:36 -0200
From:	Flavio Leitner <fbl@...hat.com>
To:	Michael Wang <wangyun@...ux.vnet.ibm.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linuxram@...ibm.com, jeffrey.t.kirsher@...el.com,
	jesse.brandeburg@...el.com
Subject: Re: Patch is wrong

On Tue, 06 Dec 2011 13:11:47 +0800
Michael Wang <wangyun@...ux.vnet.ibm.com> wrote:

> On 12/06/2011 12:39 PM, David Miller wrote:
> 
> > From: Michael Wang <wangyun@...ux.vnet.ibm.com>
> > Date: Tue, 06 Dec 2011 11:27:08 +0800
> > 
> >> I am the author of this patch, and Jeff only change 0, 1 to false
> >> and true, now he become the author.
> > 
> > Take it up with Jeff, I pulled the change from his GIT tree and
> > that's where the authorship information came from.
> > 
> 
> Hi, David
> 
> Jeff know what happened, he promised to add my and Flavio's
> signed-off-by in the pre-mail.
> 
> It's easy to see from the mail that who is the author, and I have
> reply just after Jeff's patch send out to you, I add my signed-off-by
> and From, but no one care.
> 
> I know you are all experts and have lots of patches in community, you
> won't care such a small patch's author, but this is very important for
> me because this is my first patch, it's stand for my passion and will
> to join the community.
> 

Hi Michael,

I think you should be proud of yourself because we worked from
the problem definition, then confirmation of the root cause to
the patch fixing it, which was accepted with a couple of simple
changes. However, it's still basically what we had posted.

I understand your frustration about the author thing (I've been
there). Perhaps this could be an example to sub-tree maintainers
to act more as a coach and always require the submitter to fix
the patch instead of changing it themselves, that is, like Davem
does for net and net-next trees.

Anyway, there are plenty of bugs out there to be fixed and we
will appreciate your help fixing them :)

cheers!
fbl
(sorry the late replies, I was on vacations without e-mail access)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html