netdev - Re: [PATCH net-next 1/2] bnx2x: dont handle storage drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111207.134548.419727966018690088.davem@davemloft.net>
Date:	Wed, 07 Dec 2011 13:45:48 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	barak@...adcom.com, netdev@...r.kernel.org, eilong@...adcom.com
Subject: Re: [PATCH net-next 1/2] bnx2x: dont handle storage drv_info req
 if no cnic

From: Joe Perches <joe@...ches.com>
Date: Wed, 07 Dec 2011 09:04:00 -0800

> On Wed, 2011-12-07 at 15:45 +0200, Barak Witkowski wrote:
>> This patch returns ACK with zeroed buffer to FW upon fcoe/iscsi drv_info
>> request if cnic is not defined. This is better handling in comparison to
>> send NACK to FW upon such request, as it's a valid request.
> 
> Hi Barak.
> 
> Other than the good comment,
> I think this patch isn't useful.
> It adds maintenance overhead.
> 
> It just adds more #ifdefs.
> 
> gcc should remove the call to the
> empty static void funcs.

Agreed, I'm not applying this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html