netdev - Re: [net-next PATCH 2/2] be2net: workaround to fix a BE bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111208.000044.1859009201427703594.davem@davemloft.net>
Date:	Thu, 08 Dec 2011 00:00:44 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ajit.khaparde@...lex.Com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next PATCH 2/2] be2net: workaround to fix a BE bug

From: Ajit Khaparde <ajit.khaparde@...lex.Com>
Date: Wed, 7 Dec 2011 17:44:24 -0600

> For vlan tagged pkts, BE
> 1) calculates checksum even when CSO is not requested
> 2) calculates checksum wrongly for padded pkt less than 60 bytes long.
> As a workaround disable TX vlan offloading in such cases.
 ...
> +	/* For vlan tagged pkts, BE
> +	 * 1) calculates checksum even when CSO is not requested
> +	 * 2) calculates checksum wrongly for padded pkt less than
> +	 * 60 bytes long.
> +	 * As a workaround disable TX vlan offloading in such cases.
> +	 */

This description either belongs in the commit message, or this
comment, but not both.

> +	if (unlikely(vlan_tx_tag_present(skb) &&
> +		(skb->ip_summed != CHECKSUM_PARTIAL || skb->len <= 60))) {

Poorly formatted, the second line openning first non-space character
needs to line up precisely after the first column after the if() statements
openning parenthesis.

If you cannot do this yourself by hand, use something like emacs's
C-mode to do it automatically for you when you hit TAB on that
second line.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html