netdev - Re: [net-next PATCH 2/2] be2net: workaround to fix a BE bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111208.000947.193581253177810925.davem@davemloft.net>
Date:	Thu, 08 Dec 2011 00:09:47 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	ajit.khaparde@...lex.Com, netdev@...r.kernel.org
Subject: Re: [net-next PATCH 2/2] be2net: workaround to fix a BE bug

From: Joe Perches <joe@...ches.com>
Date: Wed, 07 Dec 2011 21:07:20 -0800

> On Thu, 2011-12-08 at 00:00 -0500, David Miller wrote:
>> From: Ajit Khaparde <ajit.khaparde@...lex.Com>
>> > +	if (unlikely(vlan_tx_tag_present(skb) &&
>> > +		(skb->ip_summed != CHECKSUM_PARTIAL || skb->len <= 60))) {
>> Poorly formatted, the second line opening first non-space character
>> needs to line up precisely after the first column after the if() statements
>> opening parenthesis.
> 
> In this case I believe you mean after the unlikely(
> 
> 	if (unlikely(vlan_tx_tag_present(skb) &&
> 		     (skb->ip_summed != CHECKSUM_PARTIAL || skb->len <= 60))) {

Right.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html