netdev - Re: [PATCH] add netpoll support for 802.1q vlans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111208153558.GE30652@kvack.org>
Date:	Thu, 8 Dec 2011 10:35:58 -0500
From:	Benjamin LaHaise <bcrl@...ck.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] add netpoll support for 802.1q vlans

On Thu, Dec 08, 2011 at 12:07:30AM -0500, David Miller wrote:
> From: Benjamin LaHaise <bcrl@...ck.org>
> Date: Tue, 6 Dec 2011 20:04:24 -0500
> 
> > Add netpoll support to 802.1q vlan devices.  Based on the netpoll support 
> > in the bridging code.  Tested on a forced_eth device with netconsole.
> > 
> > Signed-off-by: Benjamin LaHaise <bcrl@...ck.org>
> 
> Bridging doesn't try to invoke a downstream netpoll operation at all,
> and neither should you.

Please have a look at net/bridge/br_device.c:br_netpoll_setup() which is 
where the approach came from.

Getting netconsole over vlans working is a requirement for those of us 
with machines plugged into ethernet switches that can't mix tagged and 
untagged packets on their ethernet ports.  I bumped into this while 
trying to capture a kernel crash on such a machine which doesn't have any 
external serial ports to use either.

> Also, please format your subject line correctly so I don't have to edit
> it when applying your patch.  You need to add an appropriate, lowercase,
> subsystem prefix after the [PATCH] tag otherwise people scanning the
> shortlog in GIT can't figure out what area your patch is in.
> 
> In this situation "vlan: " might be appropriate.

Sorry about that oversight, I'll try to remember for the future.

		-ben
-- 
"Thought is the essence of where you are now."
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html