netdev - Re: [PATCH] add netpoll support for 802.1q vlans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111208.115055.193423469660678623.davem@davemloft.net>
Date:	Thu, 08 Dec 2011 11:50:55 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bcrl@...ck.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] add netpoll support for 802.1q vlans

From: Benjamin LaHaise <bcrl@...ck.org>
Date: Thu, 8 Dec 2011 10:35:58 -0500

> On Thu, Dec 08, 2011 at 12:07:30AM -0500, David Miller wrote:
>> From: Benjamin LaHaise <bcrl@...ck.org>
>> Date: Tue, 6 Dec 2011 20:04:24 -0500
>> 
>> > Add netpoll support to 802.1q vlan devices.  Based on the netpoll support 
>> > in the bridging code.  Tested on a forced_eth device with netconsole.
>> > 
>> > Signed-off-by: Benjamin LaHaise <bcrl@...ck.org>
>> 
>> Bridging doesn't try to invoke a downstream netpoll operation at all,
>> and neither should you.
> 
> Please have a look at net/bridge/br_device.c:br_netpoll_setup() which is 
> where the approach came from.

I did and I'm not talking about that part, I'm talking about the
part where you invoke the downstream device's netpoll operation.

Did you even read my entire sentence, or did you just let the
knee jerk reaction set in before you got to the end?

> Getting netconsole over vlans working is a requirement for those of us 

What does this have to do with anything?  I never made any even remote
argument that this change wasn't useful.  I said only that you
implemented it incorrectly.

Take a deep breath and just implement the patch correctly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html