lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Dec 2011 23:06:05 +0000 From: Ben Hutchings <bhutchings@...arflare.com> To: Matt Carlson <mcarlson@...adcom.com> CC: <davem@...emloft.net>, <netdev@...r.kernel.org> Subject: Re: [PATCH net-next 4/6] tg3: Track LP advertising On Thu, 2011-12-08 at 13:50 -0800, Matt Carlson wrote: > This patch adds code to track the autonegotiation advertisements of the > link partner and report them through ethtool. > > Signed-off-by: Matt Carlson <mcarlson@...adcom.com> > Reviewed-by: Michael Chan <mchan@...adcom.com> > --- > drivers/net/ethernet/broadcom/tg3.c | 41 ++++++++++++++++++++++++++++++++-- > drivers/net/ethernet/broadcom/tg3.h | 1 + > 2 files changed, 39 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c > index d1681db..ae1e838 100644 > --- a/drivers/net/ethernet/broadcom/tg3.c > +++ b/drivers/net/ethernet/broadcom/tg3.c > @@ -3803,6 +3803,29 @@ static bool tg3_phy_copper_an_config_ok(struct tg3 *tp, u32 *lcladv) > return true; > } > > +static bool tg3_phy_copper_fetch_rmtadv(struct tg3 *tp, u32 *rmtadv) > +{ > + u32 val, lpeth = 0; > + > + if (!(tp->phy_flags & TG3_PHYFLG_10_100_ONLY)) { > + if (tg3_readphy(tp, MII_STAT1000, &val)) > + return false; > + > + lpeth = mii_stat1000_to_ethtool_lpa_t(val); > + } > + > + if (tg3_readphy(tp, MII_LPA, &val)) > + return false; > + > + lpeth |= mii_lpa_to_ethtool_lpa_t(val); > + tp->link_config.rmt_adv = lpeth; > + > + if (tg3_flag(tp, PAUSE_AUTONEG)) > + *rmtadv = val; I assume that the caller only needs this information if pause autoneg is enabled, but it's still very strange to put the condition here. Ben. > + return true; > +} [...] -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists