netdev - Re: [PATCH 0/4] skb paged fragment destructors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111209.133407.2156473837364120429.davem@davemloft.net>
Date:	Fri, 09 Dec 2011 13:34:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	Ian.Campbell@...rix.com
Cc:	eric.dumazet@...il.com, jesse.brandeburg@...el.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 0/4] skb paged fragment destructors

From: Ian Campbell <Ian.Campbell@...rix.com>
Date: Fri, 9 Dec 2011 13:47:07 +0000

> If we had a concept like MAX_SKB_PAGES then it would perhaps make
> sense to have + 2 there, but AFAICT drivers etc are already
> accounting for this appropriately by adding a further + 2 (or
> sometimes + 1) to MAX_SKB_FRAGS.

Any kind of code like this, including the "+ 2" in the skbuff header,
should be coded to use some kind of macro so we can track this
dependency instead of stumbling onto it and accidently breaking lots
of stuff if we want to change this "2" value.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html