netdev - Re: [net-next PATCH] net: netprio_cgroup: make net_prio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1323446704.2336.20.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Fri, 09 Dec 2011 17:05:04 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	nhorman@...driver.com, john.r.fastabend@...el.com,
	netdev@...r.kernel.org
Subject: Re: [net-next PATCH] net: netprio_cgroup: make net_prio_subsys
 static

Le jeudi 08 décembre 2011 à 19:53 -0500, David Miller a écrit :
> From: Neil Horman <nhorman@...driver.com>
> Date: Thu, 8 Dec 2011 06:45:55 -0500
> 
> > On Wed, Dec 07, 2011 at 09:17:17PM -0800, John Fastabend wrote:
> >> net_prio_subsys can be made static this removes the sparse
> >> warning it was throwing.
> >> 
> >> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
>  ...
> > Acked-by: Neil Horman <nhorman@...driver.com>
> 
> Applied.
> --

But it trivialy breaks the build ? Or am I mistaken ?


$ grep CONFIG_NETPRIO_CGROUP .config
CONFIG_NETPRIO_CGROUP=y

$ make net/core/netprio_cgroup.o
  CC      net/core/netprio_cgroup.o
net/core/netprio_cgroup.c:31:29: error: static declaration of ‘net_prio_subsys’ follows non-static declaration
include/linux/cgroup_subsys.h:71:1: note: previous declaration of ‘net_prio_subsys’ was here
make[1]: *** [net/core/netprio_cgroup.o] Error 1
make: *** [net/core/netprio_cgroup.o] Error 2



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html