netdev - Re: [net-next PATCH] net: netprio_cgroup: make net_prio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111209164025.GA18564@hmsreliant.think-freely.org>
Date:	Fri, 9 Dec 2011 11:40:25 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	John Fastabend <john.r.fastabend@...el.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [net-next PATCH] net: netprio_cgroup: make net_prio_subsys static

On Fri, Dec 09, 2011 at 08:31:59AM -0800, John Fastabend wrote:
> On 12/9/2011 8:05 AM, Eric Dumazet wrote:
> > Le jeudi 08 décembre 2011 à 19:53 -0500, David Miller a écrit :
> >> From: Neil Horman <nhorman@...driver.com>
> >> Date: Thu, 8 Dec 2011 06:45:55 -0500
> >>
> >>> On Wed, Dec 07, 2011 at 09:17:17PM -0800, John Fastabend wrote:
> >>>> net_prio_subsys can be made static this removes the sparse
> >>>> warning it was throwing.
> >>>>
> >>>> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> >>  ...
> >>> Acked-by: Neil Horman <nhorman@...driver.com>
> >>
> >> Applied.
> >> --
> > 
> > But it trivialy breaks the build ? Or am I mistaken ?
> > 
> 
> Dang. No your right. When its not built as a module it breaks. Sorry
> I'll revert it.
> 
Yeah, I'd say revert it for now, but I think the real problem is that the SUBSYS
macro in the cgroup core code automatically defines a subsys structure as
extern.  We should look into fixing that properly instead long term.

> > 
> > $ grep CONFIG_NETPRIO_CGROUP .config
> > CONFIG_NETPRIO_CGROUP=y
> > 
> > $ make net/core/netprio_cgroup.o
> >   CC      net/core/netprio_cgroup.o
> > net/core/netprio_cgroup.c:31:29: error: static declaration of ‘net_prio_subsys’ follows non-static declaration
> > include/linux/cgroup_subsys.h:71:1: note: previous declaration of ‘net_prio_subsys’ was here
> > make[1]: *** [net/core/netprio_cgroup.o] Error 1
> > make: *** [net/core/netprio_cgroup.o] Error 2
> > 
> > 
> > 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html