netdev - Re: vmxnet3 driver broken since 3.0?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 12:09:33 -0500
From:	chetan loke <loke.chetan@...il.com>
To:	pv-drivers@...are.com, sandr8@...il.com, zbiggy@...pl,
	netdev <netdev@...r.kernel.org>
Subject: Re: vmxnet3 driver broken since 3.0?

> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] On Behalf Of Alessandro Salvatori
> Sent: December 12, 2011 2:55 AM
> To: Zbigniew Luszpinski
> Cc: netdev@...r.kernel.org
> Subject: Re: vmxnet3 driver broken since 3.0?
>
> I guess this is the change that was introduced in 3.0 and that breaks vmxnet3:
>
> commit 55513fb4281464e97aa1ff2b9c906ca5aed917c5
> Author: Tom Herbert <therbert@...gle.com>
> Date:   Mon Oct 18 17:55:58 2010 +0000
>
>    net: fail alloc_netdev_mq if queue count < 1
>
>    In alloc_netdev_mq fail if requested queue_count < 1.
>
>    Signed-off-by: Tom Herbert <therbert@...gle.com>
>    Acked-by: Eric Dumazet <eric.dumazet@...il.com>
>    Signed-off-by: David S. Miller <davem@...emloft.net>
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 04972a4..f44d29a 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -5511,6 +5511,12 @@ struct net_device *alloc_netdev_mq(int
> sizeof_priv, const char *name,
>
>        BUG_ON(strlen(name) >= sizeof(dev->name));
>
> +       if (queue_count < 1) {
> +               pr_err("alloc_netdev: Unable to allocate device "
> +                      "with zero queues.\n");
> +               return NULL;
> +       }
> +
>        alloc_size = sizeof(struct net_device);
>        if (sizeof_priv) {
>                /* ensure 32-byte alignment of private area */
>
> thanks!
> -Alessandro-


CC'd VMware.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html