netdev - Re: [PATCH] kref: add function for reading kref value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 16:32:14 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Daniel Baluta <dbaluta@...acom.com>
Cc:	Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, adobriyan@...il.com
Subject: Re: [PATCH] kref: add function for reading kref value

Le lundi 12 décembre 2011 à 17:21 +0200, Daniel Baluta a écrit :
> On Mon, Dec 12, 2011 at 5:02 PM, Greg KH <greg@...ah.com> wrote:
> > On Mon, Dec 12, 2011 at 02:44:52PM +0200, Daniel Baluta wrote:
> >> We can easily get kref refcount value by accesing
> >> kref->refcount but it is better to have a function
> >> for this.
> >
> > No, you should NEVER need the value of the kref, if you do, you are
> > doing something wrong.
> >
> > What code needs this patch?
> 
> I plan to replace raw refcount patterns from net/ with kref, and
> I have noticed that there are some parts of code who need access
> to kref->refcount value.
> 
> e.g:
> 
> core/neighbour.c:152:			if (atomic_read(&n->refcnt) == 1 &&
> core/neighbour.c:801:			if (atomic_read(&n->refcnt) == 1 &&
> sched/cls_u32.c:459:	if (ht->refcnt == 1) {
> 

Well, its not a good idea.

kref adds nothing here.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html