netdev - Re: [PATCH] can: flexcan: fix irq flooding by clearing all interrupt sources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 16:44:01 +0100
From:	Wolfgang Grandegger <wg@...ndegger.com>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
CC:	netdev@...r.kernel.org, linux-can@...r.kernel.org,
	Reuben Dowle <Reuben.Dowle@...ico.com>,
	Lothar Waßmann <LW@...O-electronics.de>
Subject: Re: [PATCH] can: flexcan: fix irq flooding by clearing all interrupt
 sources

On 12/12/2011 04:31 PM, Marc Kleine-Budde wrote:
> On 12/12/2011 04:09 PM, Wolfgang Grandegger wrote:
>> As pointed out by Reuben Dowle and Lothar Waßmann, the TWRN_INT,
>> RWRN_INT, BOFF_INT interrupt sources need to be cleared as well
>> to avoid interrupt flooding, at least for the Flexcan on i.MX28
>> SOCs. Furthermore, the interrupts are only cleared, if really one
>> of those interrupt sources are pending (which is not the case for
>> rx and tx done).
>>
>> CC: Reuben Dowle <Reuben.Dowle@...ico.com>
>> CC: Lothar Waßmann <LW@...O-electronics.de>
>> Signed-off-by: Wolfgang Grandegger <wg@...ndegger.com>
> 
> Have you tested on mx25/mx35, does it have any negative side effects?
> My schedule is full until Friday, sorry cannot test here.

Not yet. But it's not critical. Only the pending interrupt flags are
cleared. Maybe somebody else out there could do some testing... before I
get hold of a MX35PDK board.

Wolfgang.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html