netdev - Re: [PATCH] rtnetlink: rtnl_link_register always returns zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111213.160810.785264274549847462.davem@davemloft.net>
Date:	Tue, 13 Dec 2011 16:08:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	alex.bluesman.smirnov@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] rtnetlink: rtnl_link_register always returns zero

From: alex.bluesman.smirnov@...il.com
Date: Wed, 14 Dec 2011 00:31:21 +0400

> From: Alexander Smirnov <alexander@...ovo.(none)>
> 
> Both functions 'rtnl_link_register' and '__rtnl_link_register' always
> return zero. So handling return status has no sense in several drivers.
> 
> Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@...il.com>

This is never acceptable.

As long as those routines do return a value we SHOULD NOT ignore
it.

If you ignore it, then if we do have to start returning an error
then all of these call sites have to be reverted back, which is
a waste of time.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html