netdev - Re: [patch] vlan: add rtnl_dereference() annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1323846060.2846.23.camel@edumazet-laptop>
Date:	Wed, 14 Dec 2011 08:01:00 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Patrick McHardy <kaber@...sh.net>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org, Jiri Pirko <jpirko@...hat.com>
Subject: Re: [patch] vlan: add rtnl_dereference() annotations

Le mercredi 14 décembre 2011 à 09:29 +0300, Dan Carpenter a écrit :
> The original code generates a Sparse warning:
> net/8021q/vlan_core.c:336:9:
> 	error: incompatible types in comparison expression (different address spaces)
> 
> It's ok to dereference __rcu pointers here because we are holding the
> RTNL lock.  I've added some calls to rtnl_dereference() to silence the
> warning.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> I haven't tested this, and I'm not super familiar with this code.
> Please review it carefully.
> 

Acked-by: Eric Dumazet <eric.dumazet@...il.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html