netdev - Re: [patch -next] tcp_memcontrol: fix reversed if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111215.120108.663752764643957547.davem@davemloft.net>
Date:	Thu, 15 Dec 2011 12:01:08 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	glommer@...allels.com, kuznet@....inr.ac.ru, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch -next] tcp_memcontrol: fix reversed if condition

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Thu, 15 Dec 2011 14:05:10 +0300

> We should only dereference the pointer if it's valid, not the other way
> round.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

It's nice to see how thoroughly this code has been tested, sigh...

Applied, thanks a lot Dan.

> diff --git a/net/ipv4/tcp_memcontrol.c b/net/ipv4/tcp_memcontrol.c
> index 171d7b6..7fed04f 100644
> --- a/net/ipv4/tcp_memcontrol.c
> +++ b/net/ipv4/tcp_memcontrol.c
> @@ -44,7 +44,7 @@ static inline struct tcp_memcontrol *tcp_from_cgproto(struct cg_proto *cg_proto)
>  
>  static void memcg_tcp_enter_memory_pressure(struct sock *sk)
>  {
> -	if (!sk->sk_cgrp->memory_pressure)
> +	if (sk->sk_cgrp->memory_pressure)
>  		*sk->sk_cgrp->memory_pressure = 1;
>  }
>  EXPORT_SYMBOL(memcg_tcp_enter_memory_pressure);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html