netdev - Re: [PATCH 0/13] Dumping AF_UNIX sockets via netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111216.135024.262929657289610510.davem@davemloft.net>
Date:	Fri, 16 Dec 2011 13:50:24 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	xemul@...allels.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 0/13] Dumping AF_UNIX sockets via netlink

From: Pavel Emelyanov <xemul@...allels.com>
Date: Thu, 15 Dec 2011 16:42:18 +0400

> Make the unix_diag.ko module, which is the AF_UNIX client for the sock_diag.
> 
> Use the sock_i_ino() as the primary ID key for sockets. This is currently the
> only unique (except for the sk address itself) ID of a unix socket and is de
> facto used in the ss tool to identify sockets. Thus the basic nlk request and
> response structures operate on this ID. Other socket info (sun_name, peer, etc.)
> are reported in the respective NLA-s (patches 8 through 12).
> 
> There's a locking trickery in patch #11. I've tried to study it carefully and
> checked with lockdep, but anyway, please, pay special attention to it.
> 
> The patch for ss tool is also included.
> 
> Signed-off-by: Pavel Emelyanov <xemul@...allels.com>

Looks good, applied.

I'm slightly confused by the module alias strings these diag modules
are using, can you explain it to me?

On one side it looks like it wants to see a suffix of "-${AF_INET}-${IPPROTO_TCP}"
but in the macros you pass in one numerical value, which is AF_INET minus the
protocol value.

How does that work?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html