lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 16 Dec 2011 06:06:34 +0400
From:	Glauber Costa <>
To:	KAMEZAWA Hiroyuki <>
CC:	<>, <>,
	<>, <>,
	Eric Dumazet <>,
	Stephen Rothwell <>
Subject: Re: [PATCH 2/2] Explicitly call tcp creation and init from memcontrol.c

On 12/16/2011 02:20 AM, KAMEZAWA Hiroyuki wrote:
> On Fri, 16 Dec 2011 01:13:16 +0900
> KAMEZAWA Hiroyuki<>  wrote:
>> On Thu, 15 Dec 2011 13:34:32 +0400
>> Glauber Costa<>  wrote:
>>> Walking the proto_list holds a read_lock, which prevents us from doing
>>> allocations. Splitting the tcp create function into create + init is
>>> good, but it is not enough since create_files will do allocations as well
>>> (dentry ones, mostly).
>>> Since this does not involve any protocol state, I propose we call the tcp
>>> functions explicitly from memcontrol.c
>>> With this, we lose by now the ability of doing cgroup memcontrol for
>>> protocols that are loaded as modules. But at least the ones I have in mind
>>> won't really need it (tcp_ipv6 being the only one, but it uses the same data
>>> structures as tcp_ipv4). So I believe this to be the simpler solution to this
>>> problem.
>>> Signed-off-by: Glauber Costa<>
>>> CC: Hiroyouki Kamezawa<>
>>> CC: David S. Miller<>
>>> CC: Eric Dumazet<>
>>> CC: Stephen Rothwell<>
>> Could you remake the patch onto the 'latest' linux-next ?
>> As Dave mentioned, some bandaids are already applied and this patch hunks.
> Applied patches by hand and did small test for hours.
> seems good.
> Reviewed-by: KAMEZAWA Hiroyuki<>

Thanks. But see Dave's answer to this: He'd like me to follow a slightly 
different approach (I've attached a patch earlier)

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists