netdev - Re: [PATCH net-next] net: ipv6: proc: Fix error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1324038061.2273.15.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Fri, 16 Dec 2011 13:21:01 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	igorm@....rs
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next] net: ipv6: proc: Fix error handling

Le vendredi 16 décembre 2011 à 13:05 +0100, igorm@....rs a écrit :
> From: Igor Maravic <igorm@....rs>
> 
> Fix error handling in case making of dir dev_snmp6 failes
> 
> Signed-off-by: Igor Maravic <igorm@....rs>
> ---
>  net/ipv6/proc.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ipv6/proc.c b/net/ipv6/proc.c
> index fdeb6d0..6df9035 100644
> --- a/net/ipv6/proc.c
> +++ b/net/ipv6/proc.c
> @@ -307,10 +307,10 @@ static int __net_init ipv6_proc_init_net(struct net *net)
>  		goto proc_dev_snmp6_fail;
>  	return 0;
>  
> +proc_dev_snmp6_fail:
> +	proc_net_remove(net, "snmp6");
>  proc_snmp6_fail:
>  	proc_net_remove(net, "sockstat6");
> -proc_dev_snmp6_fail:
> -	proc_net_remove(net, "dev_snmp6");
>  	return -ENOMEM;
>  }
>  

Good catch, thanks !

(Should probably be applied on net tree, not net-next)

Acked-by: Eric Dumazet <eric.dumazet@...il.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html