netdev - Re: [PATCH net-next] r8169: Support for byte queue limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFdo_mUcUXhZK20t92NJCetcPV=tst9EYTUhHdbhFU0=FjY2dA@mail.gmail.com>
Date:	Sat, 17 Dec 2011 18:28:30 +0100
From:	Igor Maravić <igorm@....rs>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next] r8169: Support for byte queue limits

> Why here in rtl8169_xmit_frags() ?
>
> If done from rtl8169_start_xmit(), you already have "dev" pointer.
>
>        netdev_sent_queue(dev, skb->len);
>

I put it there because actual dma maping is occurring in that function.
Logically there is no difference if I put it after calling of function
rtl8169_xmit_frags() in rtl8169_start_xmit().

If You think it would be better to be in function rtl8169_start_xmit,
for performance reasons I'l put it there.

In any case I'l resubmit this patch in Monday. After all it's Saturday :)
BR
Igor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html