netdev - Re: [PATCH] davinci-cpdma: fix locking issue in cpdma_chan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHFNHeUK3exXwrcjA8f6qWyasbCv_SPdJKco45jVBe7uBtuM3g@mail.gmail.com>
Date:	Sun, 18 Dec 2011 15:45:50 -0800
From:	"Palande, Ameya" <ameya.palande@...com>
To:	Ilya Yanok <yanok@...raft.com>
Cc:	netdev@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH] davinci-cpdma: fix locking issue in cpdma_chan_stop

Tested-by: Ameya Palande <2ameya@...il.com>

On Sun, Dec 18, 2011 at 12:02 PM, Ilya Yanok <yanok@...raft.com> wrote:
> Free the channel lock before calling __cpdma_chan_process to prevent
> dead lock.
>
> Signed-off-by: Ilya Yanok <yanok@...raft.com>
> ---
>  drivers/net/ethernet/ti/davinci_cpdma.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
> index dca9d33..c97d2f5 100644
> --- a/drivers/net/ethernet/ti/davinci_cpdma.c
> +++ b/drivers/net/ethernet/ti/davinci_cpdma.c
> @@ -836,11 +836,13 @@ int cpdma_chan_stop(struct cpdma_chan *chan)
>        chan_write(chan, cp, CPDMA_TEARDOWN_VALUE);
>
>        /* handle completed packets */
> +       spin_unlock_irqrestore(&chan->lock, flags);
>        do {
>                ret = __cpdma_chan_process(chan);
>                if (ret < 0)
>                        break;
>        } while ((ret & CPDMA_DESC_TD_COMPLETE) == 0);
> +       spin_lock_irqsave(&chan->lock, flags);
>
>        /* remaining packets haven't been tx/rx'ed, clean them up */
>        while (chan->head) {
> --
> 1.7.6.4
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html