netdev - Re: [PATCH 01/14] mac802154: basic ieee802.15.4 device structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111219.143248.1789452356925299625.davem@davemloft.net>
Date:	Mon, 19 Dec 2011 14:32:48 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	alex.bluesman.smirnov@...il.com
Cc:	dbaryshkov@...il.com, linux-zigbee-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH 01/14] mac802154: basic ieee802.15.4 device structures

From: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
Date: Mon, 19 Dec 2011 19:33:41 +0300

> +struct ieee802154_hw_addr_filt {
> +	u16 pan_id;
> +	u16 short_addr;
> +	u8 ieee_addr[IEEE802154_ADDR_LEN];
> +	u8 pan_coord;
> +};

What is the endianness of pan_id and short_addr objects?  You should use
the appropriate endianness types "__be16, __le16" and accessors to
represent this.

If you're storing them in cpu byte order, why?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html