netdev - Re: [PATCH] llc_cmsg_rcv was getting called after sk_eat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111219.155902.868162865948757576.davem@davemloft.net>
Date:	Mon, 19 Dec 2011 15:59:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ajuncu@...acom.com
Cc:	acme@...stprotocols.net, netdev@...r.kernel.org,
	alex.juncu@...edu.org, knaik@...acom.com, shemminger@...tta.com
Subject: Re: [PATCH] llc_cmsg_rcv was getting called after sk_eat_skb.

From: Alexandru Juncu <ajuncu@...acom.com>
Date: Fri, 16 Dec 2011 11:01:25 +0200

> Received non stream protocol packets were calling llc_cmsg_rcv that used a
> skb after that skb was released by sk_eat_skb. This caused received STP
> packets to generate kernel panics.
> 
> Signed-off-by: Alexandru Juncu <ajuncu@...acom.com>
> Signed-off-by: Kunjan Naik <knaik@...acom.com>

This bug was introduced by commit 30a584d944fbd599d4a8f470f75bf7af1a15b466:

commit 30a584d944fbd599d4a8f470f75bf7af1a15b466
Author: Stephen Hemminger <shemminger@...l.org>
Date:   Thu Aug 3 16:38:49 2006 -0700

    [LLX]: SOCK_DGRAM interface fixes

The new logic added by this fix is slightly clumsy, but seems correct
and I can't suggest a better fix at this time.

I'll apply this, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html