netdev - Re: [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111220.140209.618109781658024408.davem@davemloft.net>
Date:	Tue, 20 Dec 2011 14:02:09 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	lindner_marek@...oo.de
Cc:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org
Subject: Re: [PATCH] batman-adv: checkpatch cleanup - remove lines longer
 than 80 chars

From: Marek Lindner <lindner_marek@...oo.de>
Date: Wed, 21 Dec 2011 02:59:41 +0800

> On Wednesday, December 21, 2011 02:32:30 David Miller wrote:
>> From: Marek Lindner <lindner_marek@...oo.de>
>> Date: Tue, 20 Dec 2011 18:38:24 +0800
>> 
>> > The long line was introduced with b26e478f8f.
>> > 
>> > Signed-off-by: Marek Lindner <lindner_marek@...oo.de>
>> 
>> I'm not applying this.
>> 
>> I tell people to make sure arguments line up correctly to the
>> openning parenthesis on the previous line, and that is what is
>> happening here.
> 
> I am not against lining up the arguments but what about checkpatch ? Are we 
> going to ignore the complaints or is this line limit about to be changed ?

Refactor the code so that both constraints can be satisfied.

Is this so hard to understand?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html