netdev - Re: [PATCH net-next] sch_sfq: rehash queues in perturb timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111221.154502.1340769458825651650.davem@davemloft.net>
Date:	Wed, 21 Dec 2011 15:45:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] sch_sfq: rehash queues in perturb timer

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 21 Dec 2011 14:30:11 +0100

> A known Out Of Order (OOO) problem hurts SFQ when timer changes
> perturbation value, since all new packets delivered to SFQ enqueue might
> end on different slots than previous in-flight packets.
> 
> With round robin delivery, we can thus deliver packets in a different
> order.
> 
> Since SFQ is limited to small amount of in-flight packets, we can rehash
> packets so that this OOO problem is fixed.
> 
> This rehashing is performed only if internal flow classifier is in use.
> 
> We now store in skb->cb[] the "struct flow_keys" so that we dont call
> skb_flow_dissect() again while rehashing.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html