netdev - Re: [PATCH 2/3] netlink: use vzalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111221.180023.188534491320564804.davem@davemloft.net>
Date:	Wed, 21 Dec 2011 18:00:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] netlink: use vzalloc()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 21 Dec 2011 23:12:31 +0100

> Le mercredi 21 décembre 2011 à 13:48 -0800, Stephen Hemminger a écrit :
>> The netlink pid hash can be allocated using vzalloc() rather than direct
>> access to get_free_pages. It is also safe for nl_pid_hash_zalloc to use
>> GFP_KERNEL since it is only called from netlink_proto_init and
>> nl_pid_hash_rehash. The former is already allocating table with GFP_KERNEL,
>> and the latter is called from netlink_insert() which already could 
>> sleep in netlink_table_grab()
>> 
> 
> 
> But netlink_table_grab() returns with write_lock_irq(&nl_table_lock);
> 
> So we are not allowed to sleep in a
> netlink_table_grab()/netlink_table_ungrab() section .

Right.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html