netdev - Re: [PATCH net-next] igb: add basic runtime PM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1324432943.2327.11.camel@jtkirshe-mobl>
Date:	Tue, 20 Dec 2011 18:02:23 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	"Yan, Zheng" <zheng.z.yan@...el.com>
Cc:	Alexander Duyck <alexander.h.duyck@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	e1000-devel@...ts.sourceforge.net,
	"davem@...emloft.net" <davem@...emloft.net>,
	jesse.brandeburg@...el.com, bruce.w.allan@...el.com,
	carolyn.wyborny@...el.com, donald.c.skidmore@...el.com,
	gregory.v.rose@...el.com, peter.p.waskiewicz.jr@...el.com,
	john.ronciak@...el.com, rjw@...k.pl
Subject: Re: [PATCH net-next] igb: add basic runtime PM support

On Wed, 2011-12-21 at 09:49 +0800, Yan, Zheng wrote:
> On 12/21/2011 04:42 AM, Alexander Duyck wrote:
> > I am curious on if you have done any testing on an actual igb device
> with this code enabled?  My main concern is that the PHY is integrated
> into these parts, thus putting the MAC into D3 will result in
> behaviour changes in the PHY.  Specifically in the case of D3 the PHY
> on many of the igb parts will go into a low power link up mode, and
> may exclude a 1Gb/s link.  If this occurs I would expect to see a
> number of link issues on the device.
> > 
> I tested the code on a 82576 dual ports adapter, didn't noticed any
> issue.
> 
> > From what I can tell it looks like if you were to perform any
> ethtool operations while the link is down and this code is enabled it
> would likely result in multiple errors.  I am not sure what would
> happen if you were to run an "ethtool -t" test while the device was in
> a powered down state.
> > 
> This is not big problem because netif_device_detach() is called when
> suspending a device. "ethtool -t" reports "No such device" if the
> device is suspended. (There is a bug my patch, it doesn't calls
> netif_device_detach() if the device is down. Will send a new patch
> later) 

I will hold off on adding this patch to my queue of patches since you
intend to send a v2 of the patch.

Thanks Zheng!

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)