netdev - Re: [PATCH] ARM: net: JIT compiler for packet filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111221144346.GB3229@swarm.cs.pub.ro>
Date:	Wed, 21 Dec 2011 16:43:47 +0200
From:	Mircea Gherzan <mgherzan@...il.com>
To:	Nicolas Pitre <nico@...xnic.net>
Cc:	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	linux@....linux.org.uk
Subject: Re: [PATCH] ARM: net: JIT compiler for packet filters

On Mon, Dec 19, 2011 at 12:42:49PM -0500, Nicolas Pitre wrote:
> On Mon, 19 Dec 2011, Mircea Gherzan wrote:
> 
> > +static inline void _emit(int cond, u32 inst, struct jit_ctx *ctx)
> > +{
> > +	if (ctx->target != NULL)
> > +		ctx->target[ctx->idx] = inst | (cond << 28);
> > +
> > +	ctx->idx++;
> > +}
> 
> You might consider the patch titled "ARM: Add generic instruction opcode 
> manipulation helpers" that Dave Martin just posted and rely on it to 
> make your code compatible with BE8 mode as well.

That patch is not in devel-stable and I don't want to introduce further
dependencies for the time being. Once both patches are in mainline, I
will take a look.

> Also it seems that you are making the distinction between pre-ARMv7 and 
> ARMv7+ while in most cases it should be pre-ARMv6 and ARMv6+

Has been fixed in v2 of the patch.

Mircea
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html