netdev - Re: [PATCH net-next] tcp: Fix bug in ofo queue pruning MIB stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111221.221511.1067604757446412302.davem@davemloft.net>
Date:	Wed, 21 Dec 2011 22:15:11 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	subramanian.vijay@...il.com
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru
Subject: Re: [PATCH net-next] tcp: Fix bug in ofo queue pruning MIB stats

From: Vijay Subramanian <subramanian.vijay@...il.com>
Date: Wed, 21 Dec 2011 17:14:05 -0800

> If the counter is tracking the right thing, is it worth fixing
> netstat?

Probably.

The thing is, I can see both intepretations being useful.

If we count packets, we can't tell that OFO pruning happened 4 times
vs. we pruned 4 packets.

But if you want to know the "extent" to which OFO pruning occurs, then
you want the packet count.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html